fix: strip order_by option from query when using count()
#452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fairly standard use case is to precompose a query and then call methods like `fetch` or `count` as needed. In this case you might call `count()` on a query with an `order_by` option. Previously, if the query was also a multiquery, this could cause an error as we'd be trying to sort on the client side using data that wasn't there, because we'd converted the query to `keys_only` for purposes of getting a count. This fixes that problem by stripping `order_by` from the query options when `count()` is called. Fixes googleapis#447
googlebot
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fairly standard use case is to precompose a query and then call
methods like
fetchorcountas needed. In this case you might callcount()on a query with anorder_byoption. Previously, if the querywas also a multiquery, this could cause an error as we'd be trying to
sort on the client side using data that wasn't there, because we'd
converted the query to
keys_onlyfor purposes of getting a count.This fixes that problem by stripping
order_byfrom the query optionswhen
count()is called.Fixes #447