Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support polymodel in local structured property #497

Merged
merged 2 commits into from
Jul 31, 2020
Merged

fix: support polymodel in local structured property #497

merged 2 commits into from
Jul 31, 2020

Conversation

cguardia
Copy link
Contributor

refs #481

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 30, 2020
@cguardia cguardia requested a review from chrisrossi July 30, 2020 17:04
@cguardia cguardia added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 31, 2020
chrisrossi
chrisrossi approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@chrisrossi chrisrossi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cguardia cguardia merged commit 9ccbdd2 into googleapis:master Jul 31, 2020
@cguardia cguardia mentioned this pull request Jul 31, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisrossi chrisrossi chrisrossi approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cguardia @chrisrossi @yoshi-kokoro