Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support empty not_finished messages that cause query.count() to return early #580

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: support empty not_finished messages that cause query.count() to return early #580

merged 1 commit into from
Dec 7, 2020

Conversation

crwilcox
Copy link
Collaborator

@crwilcox crwilcox commented Dec 7, 2020

fixes #575

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Dec 7, 2020
andrewsg
andrewsg approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit fc31553 into master Dec 7, 2020
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 7, 2020
@gaborfeher
Copy link
Contributor

@crwilcox @andrewsg I've tried this on my prod data and it looks like it is causing an infinite loop. I'll write more details in the issue soon. In the meantime I think it'd be a good idea to hold off the next release.

@crwilcox
Copy link
Collaborator Author

Thanks @gaborfeher. If you identify the scenario it would be good for us to grow our test coverage to include it.

@crwilcox crwilcox mentioned this pull request Dec 11, 2020
Merged
@andrewsg
Copy link
Contributor

Thanks for the heads-up!

@gaborfeher gaborfeher mentioned this pull request Dec 12, 2020
Closed
@gaborfeher
Copy link
Contributor

@crwilcox @andrewsg I've made an issue and a PR: #584 #585

@andrewsg
Copy link
Contributor

@gaborfeher Thanks again for your help. It looks like we should be good to go now that your PR is merged. All clear?

@gaborfeher
Copy link
Contributor

@andrewsg yep, all clear from me & thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query.count() misses results sometimes
3 participants
@crwilcox @gaborfeher @andrewsg