fix: make nested retry blocks work for RPC calls #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: datastore
|
@andrewsg this is weird, if I run lint locally it passes, but Kokoro says it failed. |
andrewsg
added
the
kokoro:force-run
|
Looks like a transient error, let's run it again and cross fingers |
andrewsg
requested changes
Jan 15, 2021
google/cloud/ndb/context.py
Outdated
| @@ -544,6 +546,12 @@ def policy(key): | |||
|
|
|||
| set_memcache_timeout_policy = set_global_cache_timeout_policy | |||
|
|
|||
| def set_retry_state(self, state): | |||
| self.retry = state | |||
There was a problem hiding this comment.
This instance variable is only accessed through setters and getters, so let's indicate it's private, like self._retry
yoshi-kokoro
removed
the
kokoro:force-run
|
@andrewsg I believe this is a better approach than the original work. This removes the need for the datastore API having to know about the retry state, thus making nested retries work for other use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #567