Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly handle error when clearing cache #636

Merged
merged 4 commits into from
May 10, 2021
Merged

fix: properly handle error when clearing cache #636

merged 4 commits into from
May 10, 2021

Conversation

chrisrossi
Copy link
Contributor

Fixes #633

@chrisrossi chrisrossi requested a review from a team April 26, 2021 17:19
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 26, 2021
@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/python-ndb API. label Apr 26, 2021
@chrisrossi chrisrossi added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 26, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2021
@chrisrossi chrisrossi requested a review from a team as a code owner May 4, 2021 20:29
@chrisrossi
Copy link
Contributor Author

@craiglabenz @crwilcox PTAL?

@chrisrossi chrisrossi requested a review from tseaver May 10, 2021 14:34
@chrisrossi
Copy link
Contributor Author

Kokoro is failing due to #647 (fixed in #648).

@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@chrisrossi chrisrossi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 10, 2021
@chrisrossi chrisrossi merged commit d0ffcf3 into googleapis:master May 10, 2021
@chrisrossi chrisrossi deleted the fix-633 branch May 10, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@andrewsg andrewsg Awaiting requested review from andrewsg

@craiglabenz craiglabenz Awaiting requested review from craiglabenz

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/python-ndb API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Strict variable referenced before initialization
3 participants
@chrisrossi @tseaver @yoshi-kokoro