Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage Update Conformance Tests #117

Closed
frankyn opened this issue Apr 25, 2020 · 1 comment · Fixed by #118
Closed

Storage Update Conformance Tests #117

frankyn opened this issue Apr 25, 2020 · 1 comment · Fixed by #118
Assignees
@IlyaFaer
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@frankyn
Copy link
Member

frankyn commented Apr 25, 2020

The Storage library support for Post Policy V4 has a security risk that is addressed in the latest PR to Storage conformance tests: googleapis/conformance-tests#31

The fix is to add {"bucket":"bucket-name"} to Post Policy V4 policy which is then signed.

Here's an example solution in Ruby: googleapis/google-cloud-ruby#5702
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Apr 25, 2020
@frankyn frankyn added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 25, 2020
@IlyaFaer
Copy link

@frankyn, I'm already in progress, I just have had some internet problems in the first half of the day.
Planning to push today.

@IlyaFaer IlyaFaer mentioned this issue Apr 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaFaer IlyaFaer

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add bucket name into POST policy conditions MaxxleLLC/python-storage
2 participants
@frankyn @IlyaFaer