Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: propagate timeout in BlobWriter #1186

Merged
merged 3 commits into from
Dec 4, 2023
Merged

fix: propagate timeout in BlobWriter #1186

merged 3 commits into from
Dec 4, 2023

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Nov 17, 2023

Fixes #1184

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Nov 17, 2023
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2023
@cojenco cojenco marked this pull request as ready for review November 17, 2023 22:51
@cojenco cojenco requested review from a team as code owners November 17, 2023 22:51
danielduhh
danielduhh approved these changes Nov 20, 2023
View reviewed changes
google/cloud/storage/fileio.py Outdated Show resolved Hide resolved
@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 27, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 27, 2023
andrewsg
andrewsg approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 4, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 4, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 22f36da into googleapis:main Dec 4, 2023
15 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 4, 2023
@release-please release-please bot mentioned this pull request Dec 4, 2023
Merged
@parthea parthea mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@danielduhh danielduhh danielduhh approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadTimeout errors
3 participants
@cojenco @andrewsg @danielduhh