Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add *generation*match args into Blob.compose() #122

Merged
merged 14 commits into from
Jun 9, 2020
Merged

feat: add *generation*match args into Blob.compose() #122

merged 14 commits into from
Jun 9, 2020

Conversation

IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Apr 30, 2020 •
edited
Loading

Add ifGenerationMatch and ifMetagenerationMatch arguments into Blob.compose() method.
Towards #127

@IlyaFaer IlyaFaer added api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Apr 30, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 30, 2020
@IlyaFaer IlyaFaer requested a review from frankyn April 30, 2020 13:35
@IlyaFaer IlyaFaer marked this pull request as ready for review April 30, 2020 13:35
@frankyn frankyn mentioned this pull request May 4, 2020
Closed
andrewsg
andrewsg requested changes May 5, 2020
View reviewed changes
google/cloud/storage/blob.py Show resolved Hide resolved
tests/system/test_system.py Show resolved Hide resolved
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 13, 2020
frankyn
frankyn approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending @andrewsg approval.

@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 1, 2020
andrewsg
andrewsg approved these changes Jun 2, 2020
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 2, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 3, 2020
@IlyaFaer IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 4, 2020
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 8, 2020
@frankyn frankyn merged commit dc01c59 into googleapis:master Jun 9, 2020
@IlyaFaer IlyaFaer deleted the compose_generation_match branch June 10, 2020 07:26
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@frankyn @cojenco
feat: add *generation*match args into Blob.compose() (googleapis#122)
0a3ddc5 
* feat: add *generation*match args into Blob.compose()

* add test case with error

* new compose surface

* Revert "new compose surface"

This reverts commit 2ddda40.

* add an error for different length args, add a usage example

* add condition to avoid sending params with None

* specify comments

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@frankyn @cojenco
feat: add *generation*match args into Blob.compose() (googleapis#122)
fb67895 
* feat: add *generation*match args into Blob.compose()

* add test case with error

* new compose surface

* Revert "new compose surface"

This reverts commit 2ddda40.

* add an error for different length args, add a usage example

* add condition to avoid sending params with None

* specify comments

Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankyn frankyn frankyn approved these changes

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@IlyaFaer @andrewsg @frankyn @googlebot @yoshi-kokoro