Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add integration test for universe domain #1346

Merged
merged 4 commits into from
Sep 25, 2024
Merged

feat: add integration test for universe domain #1346

merged 4 commits into from
Sep 25, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Sep 20, 2024

No description provided.

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/python-storage API. labels Sep 20, 2024
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2024
@cojenco cojenco marked this pull request as ready for review September 23, 2024 16:32
@cojenco cojenco requested review from a team as code owners September 23, 2024 16:32
andrewsg
andrewsg approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cojenco cojenco added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 24, 2024
@cojenco cojenco added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 25, 2024
@cojenco cojenco added the automerge Merge the pull request once unit tests and other checks pass. label Sep 25, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 02a972d into googleapis:main Sep 25, 2024
13 of 14 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 25, 2024
@release-please release-please bot mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseLovelace JesseLovelace JesseLovelace approved these changes

@andrewsg andrewsg andrewsg approved these changes

Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cojenco @andrewsg @JesseLovelace @yoshi-kokoro