Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add restore_bucket and handling for soft-deleted buckets #1365

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Feat: Add restore_bucket and handling for soft-deleted buckets #1365

merged 5 commits into from
Oct 29, 2024
+412 −18

Conversation

andrewsg
Copy link
Contributor

@andrewsg andrewsg commented Oct 17, 2024 •
edited by cojenco
Loading

fixes #1347

@andrewsg andrewsg requested review from a team as code owners October 17, 2024 22:52
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/python-storage API. labels Oct 17, 2024
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 21, 2024
@andrewsg andrewsg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 22, 2024
cojenco
cojenco reviewed Oct 28, 2024
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you working on this while dealing with the whole credentials/secrets situation. I have some questions... and was wondering if we have the most recent user guide/docs?

tests/system/test_client.py Show resolved Hide resolved
google/cloud/storage/bucket.py Outdated Show resolved Hide resolved
google/cloud/storage/client.py Outdated Show resolved Hide resolved
google/cloud/storage/client.py Outdated Show resolved Hide resolved
google/cloud/storage/client.py Show resolved Hide resolved
google/cloud/storage/client.py Show resolved Hide resolved
cojenco
cojenco approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrew!

@andrewsg andrewsg merged commit ab94efd into main Oct 29, 2024
14 checks passed
@andrewsg andrewsg deleted the bucket-restore branch October 29, 2024 19:40
@release-please release-please bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@JesseLovelace JesseLovelace Awaiting requested review from JesseLovelace

Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Bucket Restore
3 participants
@andrewsg @cojenco @yoshi-kokoro