Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expose num_retries parameter for blob upload methods #353

Merged
merged 2 commits into from
Feb 10, 2021
Merged

fix: expose num_retries parameter for blob upload methods #353

merged 2 commits into from
Feb 10, 2021

Conversation

HemangChothani
Copy link
Contributor

Fixes #352

@HemangChothani HemangChothani requested review from tseaver, andrewsg and a team December 23, 2020 07:31
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 23, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 23, 2020
andrewsg
andrewsg approved these changes Feb 10, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awkward to add an already-deprecated argument to other methods, but I agree we should at least be consistent about exposing this until we have full configuration support. Thanks!

@andrewsg andrewsg requested a review from a team as a code owner February 10, 2021 21:33
@andrewsg andrewsg added the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit fdabd6a into googleapis:master Feb 10, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 10, 2021
This was referenced Mar 11, 2021
Closed
Closed
Merged
Merged
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: expose num_retries parameter for blob upload methods (googleapis…
d44488e 
…#353)

Fixes googleapis#352
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
@HemangChothani @cojenco
fix: expose num_retries parameter for blob upload methods (googleapis…
c1aa23a 
…#353)

Fixes googleapis#352
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

@tseaver tseaver Awaiting requested review from tseaver

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document recommendations for retrying blob.upload_from_filename
2 participants
@HemangChothani @andrewsg