feat(storage): improve v4 signature query parameters encoding #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
IlyaFaer
commented
Feb 10, 2020
IlyaFaer
added
the
type: feature request
crwilcox
approved these changes
Feb 11, 2020
|
@IlyaFaer this LGTM, but please update relevant conformance tests before merging this code to confirm that it's working as expected. I updated conformance tests in https://github.com/googleapis/conformance-tests/tree/master/storage/v1 If you have questions PLMK. Specifically for this change you should rely on the following two conformance tests:
|
IlyaFaer
pushed a commit
to MaxxleLLC/conformance-tests
that referenced
this pull request
Feb 12, 2020
tseaver
previously requested changes
Feb 12, 2020
|
This PR also addresses part of the change for #12. |
This was referenced Feb 12, 2020
tseaver
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
frankyn
approved these changes
Feb 13, 2020
tseaver
reviewed
Feb 13, 2020
|
Friendly ping and pending Kokoro passing. |
|
Merging when green. |
|
Pending approval from @tseaver as there is on-going discussion. |
|
@tseaver friendly ping |
crwilcox
approved these changes
Mar 6, 2020
crwilcox
dismissed
tseaver’s stale review
Reviewed, attempted to remove coercion, but due to truthiness of bytes and strs in python 2 I am going to approve this.
crwilcox
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
crwilcox
added
the
automerge
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…apis#48) * feat(storage): improve v4 signature query parameters encoding * add URL encoding test * add query_parameters arg into conformance tests * add tests for _quote_param() function * declare test file encoding * fix the param type * add test with bytes * Update _signing.py Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Christopher Wilcox <crwilcox@google.com>
cojenco
pushed a commit
to cojenco/python-storage
that referenced
this pull request
Oct 13, 2021
…apis#48) * feat(storage): improve v4 signature query parameters encoding * add URL encoding test * add query_parameters arg into conformance tests * add tests for _quote_param() function * declare test file encoding * fix the param type * add test with bytes * Update _signing.py Co-authored-by: Frank Natividad <frankyn@users.noreply.github.com> Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9