Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add turbo replication support and samples #622

Merged
merged 27 commits into from
Jan 18, 2022
Merged

feat: add turbo replication support and samples #622

merged 27 commits into from
Jan 18, 2022

Conversation

unforced
Copy link
Contributor

@unforced unforced commented Oct 13, 2021 •
edited
Loading

Fixes #605 and #606

@unforced unforced requested a review from ddelgrosso1 October 13, 2021 19:33
@unforced unforced requested review from a team as code owners October 13, 2021 19:33
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 19, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@unforced unforced changed the title feat: add turbo replication support feat: add turbo replication support and samples Oct 19, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 20, 2021
cojenco
cojenco approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! A few nits, otherwise LGTM

@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 8, 2021
@ddelgrosso1
Copy link
Contributor

This can be merged / released now.

@unforced unforced removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 12, 2022
@unforced unforced requested a review from a team as a code owner January 12, 2022 15:54
@unforced unforced requested a review from nicain January 12, 2022 15:54
@unforced unforced added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 12, 2022
@dandhlee dandhlee added cla: yes This human has signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jan 12, 2022
@unforced unforced mentioned this pull request Jan 18, 2022
Closed
@unforced unforced merged commit 4dafc81 into googleapis:main Jan 18, 2022
@release-please release-please bot mentioned this pull request Jan 18, 2022
Merged
@cojenco cojenco mentioned this pull request Feb 9, 2022
Closed
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandhlee dandhlee dandhlee left review comments

@cojenco cojenco cojenco approved these changes

@tseaver tseaver tseaver left review comments

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for turbo replication
6 participants
@unforced @ddelgrosso1 @tseaver @cojenco @dandhlee @yoshi-kokoro