-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
I borked the repo name in the kokoro config 😆. Will re-run shortly. |
I believe the long term plan is for our team to eventually update and maintain the handwritten libraries for this. It may be worthwhile keeping the existing API surface around instead of forcing customers to switch back and forth That being said, I don't think Trace is going to be on our radar for a while. And I'm not familiar with the library, so I'd have to do some digging to see if the existing hand-written part is even worth keeping. It looks pretty light weight. I'd probably prefer to go fully auto-generated for now and re-assess later (if the customer impact isn't too high). What do you think @simonz130? |
I think it's uncommon for folks to interact with this library directly. It looks like the docs push folks to interact with the Trace API via OpenCensus or OpenTelemetry. https://cloud.google.com/trace/docs/client-libraries
The OpenCensus StackDriver Trace Exporter declares |
We should trim the manual layer from this library and make a major release as a result. We should focus on steering folks to use OT exporter instead of this library directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, that makes sense to me
Thanks @simonz130 @daniel-sanche! I'll cut a release on Monday. |
🤖 I have created a release \*beep\* \*boop\* --- ## [1.0.0](https://www.github.com/googleapis/python-trace/compare/v0.24.0...v1.0.0) (2020-09-14) ### ⚠ BREAKING CHANGES * migrate to microgenerator (#29) ### Features * migrate to microgenerator ([#29](https://www.github.com/googleapis/python-trace/issues/29)) ([f0d9d91](https://www.github.com/googleapis/python-trace/commit/f0d9d9161d7aee344ad1765c477947cd04505bf5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Thanks for getting this done. I've pinged the Cloud Trace team in case they want to follow up, but it looks great! |
This library has a manual surface that calls out to the GAPIC layer. I suspect this is mainly because of when this library was written. See PR for context.
The only added functionality seems to be a stored
project_id
. This PR removes the handwritten layer since the costs of maintaining that handwritten layer seem greater than the benefits. The addition of proto plus makes the other helpers (dict to protobuf and datetime conversion) obsolete.There is a directory of samples written against the new surface to help folks who were using the manual wrapper adjust their code.
CC @simonz130 and @daniel-sanche since this is one of the Stackdriver libraries.