Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pull-request-header and pull-request-footer to action's input #1001

Open
lacolaco opened this issue May 24, 2024 · 0 comments
Open

Add pull-request-header and pull-request-footer to action's input #1001

lacolaco opened this issue May 24, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@lacolaco
Copy link

lacolaco commented May 24, 2024

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.

Since v4, pull-request-header and pull-request-footer are only set in config JSON file. In JSON, it is not convenient to set multi-lines string. Until v3, I could read the content from file and pass it to the action's input like below;

- name: Get header
  id: release-please-header
  run: echo "content=$(cat release-please-header.md)" >> $GITHUB_OUTPUT
- use: googleapis/release-please@v3
  with: 
    pull-request-header: ${{ steps.release-please-header.outputs.content }}

And, currently config-file is respected only when manifest json is loaded. Without manifest file, there is no way to configure pull-request-header and footer.

Describe the solution you'd like

Add pull-request-header and pull-request-footer inputs to release-please-actions.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@lacolaco lacolaco added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant