Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releasing from alternate path fails to find prior release #1132

Closed
bcoe opened this issue Nov 30, 2021 · 1 comment · Fixed by #1146
Closed

Releasing from alternate path fails to find prior release #1132

bcoe opened this issue Nov 30, 2021 · 1 comment · Fixed by #1146
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone

Comments

@bcoe
Copy link
Contributor

bcoe commented Nov 30, 2021

When releasing from alternate path, with --monorepo-tags, v13 of release-please fails to find prior release, resulting in bad release proposal, see:

conventional-changelog/conventional-changelog#874

Reproducing

node ./build/src/bin/release-please.js release-pr --release-type=node --token=$GITHUB_TOKEN --path=packages/conventional-changelog-cli --monorepo-tags --package-name=conventional-changelog-cli --repo-url=conventional-changelog/conventional-changelog --dry-run

Expected Output

Ideally we'd be able to bootstrap the library based on the prior tags, or based on a manifest?

@bcoe bcoe added priority: p2 Moderately-important priority. Fix may not be included in next release. help wanted We'd love to have community involvement on this issue. type: question Request for information or clarification. Not an issue. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Nov 30, 2021
@bcoe
Copy link
Contributor Author

bcoe commented Dec 1, 2021

@chingor13 update, I've tried creating an initial release tagged to an earlier point in history, which did not work:

https://github.com/conventional-changelog/conventional-changelog/releases/tag/conventional-changelog-cli-v2.2.1

I also tried creating a branch with the appropriate naming convention:

https://github.com/conventional-changelog/conventional-changelog/tree/release-please--branches--master--components--conventional-changelog-cli

And finally, adding a manifest with a bootstrap sha:

https://github.com/conventional-changelog/conventional-changelog/blob/master/release-please-config.json

In all cases it fails to find a working set of commits for the conventional-changelog-cli submodule.

@bcoe bcoe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: question Request for information or clarification. Not an issue. help wanted We'd love to have community involvement on this issue. labels Dec 6, 2021
@bcoe bcoe added this to the v13 milestone Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants