Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linked-versions and node-workspace plugins are incompatible #1457

Closed
phated opened this issue May 31, 2022 · 1 comment · Fixed by #1550
Closed

linked-versions and node-workspace plugins are incompatible #1457

phated opened this issue May 31, 2022 · 1 comment · Fixed by #1550
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@phated
Copy link
Contributor

phated commented May 31, 2022

Environment details

  • OS: Linux / GHA
  • Node.js version: 12 (I think?)
  • npm version: N/A
  • release-please version: 13.16.5 (v3.2.5 of the action)

Steps to reproduce

  1. Create a "linked-versions" manifest config
  2. Add "node-workspace" plugin
  3. Try to create a release

Once the node-workspace plugin is run, it crashes (?) because it expects a version to exist on the PullRequest that linked-versions produced.
@phated phated added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 31, 2022
@phated phated mentioned this issue May 31, 2022
Merged
@chingor13
Copy link
Contributor

Apologies on the slow response to this. This is going to probably require a non-trivial change to the plugins. The workspace plugin is updating files directly and not creating a new pull request for components that require a version bump. Then the linked versions plugin has no notion that another component was touched and that it's version needs to be linked to others.

@chingor13 chingor13 self-assigned this Jul 26, 2022
@chingor13 chingor13 mentioned this issue Aug 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow plugins to skip merging in-scope pull requests googleapis/release-please
2 participants
@chingor13 @phated