-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple paths for package in manifest release #1581
Comments
I'm unfamiliar with Turborepo, but we have a concept of |
@chingor13 I am in need of this feature as well. Are there any workspace plugins that work for Go projects? |
I was envisioning something like this is the config:
So that if anything in my |
@hspitzley-czi I think that's what the node-workspace plugin is supposed to do. Unfortunately, I haven't had the time to try it out. It's on our backlog though. |
My understanding was that that plugin was specific to nodejs so I was hoping for a language agnostic solution that would allow me to define dependencies in my Go monorepo |
I just tried this out, it does not as expected yet.
when only change files in |
We make great use of Release-Please in the OpenFeature project. We're interested in implementing something like this... either a generic plugin or an enhancement to the existing manifest-releaser to support "local" dependencies. Something like the "linked version" behavior, but not bidirectional: so if @chingor13 does this strike you as a reasonable proposal? |
This does seem very similar to what the workspace plugins are doing, but with a different versioning strategy -- where the semver bump type is matched. It might be possible to modify the workspace plugins to accept a versioning strategy configuration where it knows the version type change of the source artifact and it matches that version type change when it bumps the dependee artifact. A language-independent plugin is hard because it needs to know which files to update, unless you are going to only rely on the configuring generic updaters ( |
We rely on the inline comment markers like this ( (which I guess are powered by the generic updaters?). We find these work nicely. We use them heavily for updating documentation, etc, so it's no issue for us. |
I would appreciate something like this for managing a monorepo containing a number of C++ projects. Language specific version updates are not of great interest in this case either. Though it does seem like using the A simple way to model that X package incorporates extra code from specific paths, and conventional commits to those paths affect the version number as if they where in the directory of X package would greatly simplify shared code scenarios. |
@chingor13 Are you in favor of having an implementation for this? I will happily do it if it's something I know isn't a dead-end. |
Any news related to this? I think it would be super useful to have this feature 🙏 |
Is it possible to have multiple paths trigger a release for a package in the
release-please-config.json
?I'm using Turborepo, which has
apps
andpackages
directories which contain apps and libraries, respectively. I would like it if updates to a specificpackage
triggered a release for anapp
.Can this be achieved, currently?
The text was updated successfully, but these errors were encountered: