Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many Java monorepo modules have the same release note from java-analytics-data #1705

Closed
suztomo opened this issue Oct 14, 2022 · 2 comments
Closed

Many Java monorepo modules have the same release note from java-analytics-data #1705

suztomo opened this issue Oct 14, 2022 · 2 comments
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@suztomo
Copy link
Member

suztomo commented Oct 14, 2022 •
edited
Loading

In this release please pull request googleapis/google-cloud-java#8610, the release notes in many modules have these two new features:

[analyticsdata] add subject_to_thresholding field to ResponseMetadata type (#8545) (8fdc6c1)
add tokens_per_project_per_hour field to PropertyQuota type (8fdc6c1)

However they are file changes in java-analytics-data module committed in https://github.com/googleapis/google-cloud-java/pull/8545/files. These release notes should only appear in google-analytics-data.

Screen Shot 2022-10-25 at 11 10 43 AM
@suztomo suztomo added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 14, 2022
@suztomo suztomo changed the title Many Java monorepo modules have the same release note from java-analyticsdata Many Java monorepo modules have the same release note from java-analytics-data Oct 14, 2022
@chingor13
Copy link
Contributor

This is a bug in how that PR was merged. googleapis/google-cloud-java@8fdc6c1 is the offending commit which touches no files. By design, a commit with no files applies to all components (to support forced commit messages like:

chore: fix version

Release-As: 1.2.3

@chingor13 chingor13 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2022
@suztomo
Copy link
Member Author

suztomo commented Oct 27, 2022 •
edited
Loading

Thank you for investigation. I guess it touched no files because the changes were already applied in a previous "[Many APIs]" pull request.

I think this situation is common in monorepos, especially when we regenerate OwlBot'a "owl-bot-copy" pull requests. We'll see whether this recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@suztomo @chingor13