Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: issue a combined PR comment for all releases #2286

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: issue a combined PR comment for all releases #2286

merged 2 commits into from
Jun 6, 2024

Conversation

niieani
Copy link
Contributor

@niieani niieani commented May 10, 2024

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2285 馃

Addresses both the issue of multiple comments, as well as formatting the URLs in the comment.

@niieani
feat: issue a combined PR comment for all releases
8800d05 
also fixes the release URL with non-ascii characters

fixes googleapis#2285
@niieani niieani requested review from a team as code owners May 10, 2024 17:57
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 10, 2024
@chingor13 chingor13 merged commit 719fdf5 into googleapis:main Jun 6, 2024
11 checks passed
@release-please release-please bot mentioned this pull request Jun 6, 2024
Merged
@niieani niieani deleted the fix-comments branch June 8, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
2 participants
@niieani @chingor13