Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please include Version.java in VERSION_REPLACEMENT_FILENAMES #597

Closed
igorbernstein2 opened this issue Oct 16, 2020 · 1 comment · Fixed by googleapis/repo-automation-bots#1629
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
I would like to have a robust way to embed my client's version in the client. This is necessary to enable DirectPath despite customer applications shading client artifacts.

Describe the solution you'd like
I would like to add a Version.java file to bigtable client and it be auto updated during release. Currently I either have rely on resource filtering gymnastics or hijack the existing allowlist entry for GoogleUtils.java

Describe alternatives you've considered

  1. Using resource filtering gymnastics to populate files with a version from a maven property. This is pretty clunky and will probably cause issues when importing in g3
  2. Using the already allowlisted GoogleUtils.java. This is a bit hacky and intended for a different audience.

Additional context
googleapis/java-bigtable#451

@bcoe
Copy link
Contributor

bcoe commented Oct 21, 2020

@igorbernstein2 @chingor13, I believe we'd actually need to make this change here:

https://github.com/googleapis/release-please

@chingor13 chingor13 transferred this issue from googleapis/releasetool Oct 21, 2020
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Oct 21, 2020
@chingor13 chingor13 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 21, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Oct 21, 2020
gcf-merge-on-green bot pushed a commit to googleapis/repo-automation-bots that referenced this issue Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants