Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for fixing semver of the release on multi-module projects #802

Closed
chingor13 opened this issue Feb 25, 2021 · 3 comments
Closed
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@chingor13
Copy link
Contributor

For multimodule releases, using Release-As: x.y.z may not suffice - it's not necessarily clear which module versions this should override.

The use case is for trying to fix a release version. Consider the case where we accidentally merge a breaking change commit message, but it wasn't actually a breaking change. It would be nice to be able to go back and somehow fix the commit message.

Potential options:

  • if a semver label is applied to the PR, assume that semver bump type over the commit message
  • add a Release-Semver: [major|minor|patch] git trailer that will override the semver bump we use on all modules in the proposed pull request
@sofisl sofisl added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Feb 25, 2021
@stephaniewang526
Copy link

stephaniewang526 commented Mar 10, 2021

An example in java-bigquerystorage where a breaking change in v1beta2 resulted in a client major version bump in the release PR proposed by release-please. It should've been a minor bump. Manual changes were required to fix all the pom files, versions.txt, and PR subject line.

@kolea2
Copy link

kolea2 commented Apr 16, 2021

Adding example for java-bigtable-hbase: googleapis/java-bigtable-hbase#2825. We would have liked all version numbers to be bumped in this case

@chingor13
Copy link
Contributor Author

#1161 allows you to override the commit message of the merged pull request. This should work to "undo" the breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants