Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-goog-api-client is incorrect when the customer uses shading #1313

Open
igorbernstein2 opened this issue Oct 7, 2020 · 0 comments
Open

x-goog-api-client is incorrect when the customer uses shading #1313

igorbernstein2 opened this issue Oct 7, 2020 · 0 comments
Labels
gax priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link
Contributor

The current approach pulls the version from the jar manifest. Unfortunately this will break if the application builds an uber jar (the version will come from the uber jar rather then the generated client or gax). A more robust approach would to follow grpc's approach and embed it in a class or to use the maven-resources-plugin. I recently worked around this issue in the bigtable client:
googleapis/java-bigtable#451
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 8, 2020
@miraleung miraleung added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 15, 2020
elharo referenced this issue in GoogleCloudPlatform/cloud-opensource-java Oct 29, 2020
@elharo
Shading often corrupts non-code metadata in META-INF/MANIFEST.mf
bee1a4a 
@suztomo Inspired by https://github.com/googleapis/gax-java/issues/1207
@elharo elharo mentioned this issue Oct 29, 2020
Merged
elharo referenced this issue in GoogleCloudPlatform/cloud-opensource-java Nov 3, 2020
@elharo
Shading often corrupts non-code metadata in META-INF/MANIFEST.mf (#1762)
020c618 
* Shading often corrupts non-code metadata in META-INF/MANIFEST.mf

@suztomo Inspired by https://github.com/googleapis/gax-java/issues/1207

* review
@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 12, 2022
@ddixit14 ddixit14 transferred this issue from googleapis/gax-java Feb 8, 2023
@ddixit14 ddixit14 added the gax label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gax priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@miraleung @meltsufin @igorbernstein2 @yoshi-automation @ddixit14