Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a downstream check for spring-cloud-gcp #2534

Closed
blakeli0 opened this issue Mar 4, 2024 · 2 comments · Fixed by #3092
Closed

Add a downstream check for spring-cloud-gcp #2534

blakeli0 opened this issue Mar 4, 2024 · 2 comments · Fixed by #3092
Assignees
@diegomarquezp
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@blakeli0
Copy link
Collaborator

blakeli0 commented Mar 4, 2024

spring-cloud-gcp is dependent on gapic-generator-java-bom, we should make sure that any changes in this repo should not break spring-cloud-gcp by adding a downstream check. This happened in the past that a change in TestProtoLoader break SpringCodeGen, see GoogleCloudPlatform/spring-cloud-gcp#2570.
@blakeli0 blakeli0 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 4, 2024
@blakeli0 blakeli0 mentioned this issue Mar 4, 2024
Closed
@diegomarquezp
Copy link
Contributor

@blakeli0 Do we only want to check autoconfig generation?

@diegomarquezp
Copy link
Contributor

From discussion with @blakeli0, let's limit the scope to updating the generator

@diegomarquezp diegomarquezp self-assigned this Jul 30, 2024
@diegomarquezp diegomarquezp mentioned this issue Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diegomarquezp diegomarquezp

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: add downstream check for spring-cloud-gcp googleapis/sdk-platform-java
2 participants
@blakeli0 @diegomarquezp