fix: do not omit arguments retrieved from docstring #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
parthea
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #93, I've omitted arguments that didn't have docstring entries or didn't have types specified as part of the feedback for cloud site documents. However this had a side effect of leaving out more arguments than we needed.
Fixing this by keeping a track of number of arguments the function comes with. If
argslist is not empty, it'll loop through all the variables we extract from the docstring. If the function didn't have well formatted arguments, we should still loop through what we retrieved from the docstring to see if we have any info that we've retrieved throughsummary_info['variables']that we can add to.Fixes #113.
Not having goldens is really biting me, but at least now I have a good idea what I need to base the golden data off of. I'll work on it the first thing after we launch.