Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update markdown header parser #177

Merged
merged 3 commits into from
Feb 7, 2022
Merged

fix: update markdown header parser #177

merged 3 commits into from
Feb 7, 2022

Conversation

dandhlee
Copy link
Collaborator

@dandhlee dandhlee commented Feb 6, 2022

There is an issue on some markdown pages that contain the license header. Unfortunately the markdown plugin did not seem to handle this well and appended the title to the end of the markdown comment, making it harder to parse the header.

Updating the parser to simply look for the start of the header, strip everything afterwards to try and retrieve the header better.

Fixes b/218150724.

  • Tests pass

@dandhlee dandhlee requested a review from a team February 6, 2022 10:24
@dandhlee dandhlee requested a review from a team as a code owner February 6, 2022 10:24
@dandhlee dandhlee merged commit 71d50cc into main Feb 7, 2022
@dandhlee dandhlee deleted the fix_md_header branch February 7, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants