Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove function and method name override #42

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

dandhlee
Copy link
Collaborator

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.


We opted to shorten the names displayed on the functions so that we don't show duplicated name and syntax to the users. The syntax is already captured inside syntax['content'] field, so no need to duplicate it back into the name field.

  • Tests pass
  • Appropriate changes to README are included in PR

@dandhlee dandhlee added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 16, 2021
@dandhlee dandhlee requested a review from tbpg June 16, 2021 03:54
@dandhlee dandhlee requested a review from a team as a code owner June 16, 2021 03:54
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@dandhlee
Copy link
Collaborator Author

#22 made this fix for References and other entries where applicable conditions apply (whenever _create_reference function is called), while this PR updates for Function and Method types.

@dandhlee dandhlee merged commit ab8f265 into master Jun 16, 2021
@dandhlee dandhlee deleted the dandhlee-patch-1 branch June 16, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants