Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: keep Python COC, update README #6

Merged
merged 2 commits into from
Mar 25, 2021
Merged

docs: keep Python COC, update README #6

merged 2 commits into from
Mar 25, 2021

Conversation

dandhlee
Copy link
Collaborator

Before you open a pull request, note that this repository is forked from here.
Unless the issue you're trying to solve is unique to this specific repository,
please file an issue and/or send changes upstream to the original as well.


updating README and removing one of the duplicate COC, keeping the one that's available in other Python repositories.

  • Tests pass
  • Appropriate changes to README are included in PR

@dandhlee dandhlee requested a review from a team March 25, 2021 17:51
@dandhlee dandhlee self-assigned this Mar 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 25, 2021
README.rst Outdated

pip install gcp-sphinx-docfx-yaml

To use the default original, install original docfx-yaml:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can delete this and the command below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean just the second part of the original snippet? or the pip install for gcp-sphinx-docfx-yaml as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to say how to install the original. How to install this one is good to keep.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. Just got confused by the range of snippet shown on the front page D:

@dandhlee dandhlee merged commit 3a60b1a into master Mar 25, 2021
@dandhlee dandhlee deleted the docs branch March 25, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants