Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxSockets is not passed to the underlying agent when forever:true #148

Closed
zamnuts opened this issue Mar 31, 2020 · 0 comments · Fixed by #149
Closed

maxSockets is not passed to the underlying agent when forever:true #148

zamnuts opened this issue Mar 31, 2020 · 0 comments · Fixed by #149
Assignees
@zamnuts
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@zamnuts
Copy link
Contributor

zamnuts commented Mar 31, 2020

While troubleshooting the issue googleapis/nodejs-bigquery#624 it was found that despite @google-cloud/common/util declaring maxSockets, this isn't actually propagated down to the HTTP/S agent that teeny-request uses, and maxSockets always defaults to Infinity.

Note that a new Agent is only used either when a proxy is defined, or when forever: true; the Node.js globalAgent is used in all other cases.

Environment details

  • OS: linux
  • Node.js version: 10.19.0
  • npm version: 6.14.4
  • teeny-request version: 6.0.3
@zamnuts zamnuts mentioned this issue Mar 31, 2020
Merged
4 tasks
@zamnuts zamnuts self-assigned this Mar 31, 2020
@zamnuts zamnuts mentioned this issue Mar 31, 2020
Closed
@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Apr 1, 2020
@bcoe bcoe added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 3, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zamnuts zamnuts

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: pass agent options when using agent pool config googleapis/teeny-request
3 participants
@bcoe @zamnuts @yoshi-automation