misc: update sample_v2 artifacts #8243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Apr 13, 2019
| // 1) The string|boolean story for proto | ||
| // 2) Travis gets a absolute path during yarn diff:sample-json | ||
| delete lhr.configSettings.auditMode; | ||
| lhr.configSettings.auditMode = true; |
There was a problem hiding this comment.
this is valid, it's just as if we were running audit mode from the default location instead of from the saved artifacts
brendankenny
commented
Apr 13, 2019
| return !item.explanation.includes('Required RobotsTxt gatherer did not run') && | ||
| !item.explanation.includes('Required TapTargets gatherer did not run'); | ||
| }); | ||
| assert.deepStrictEqual(unexpectedErrrors, [], 'Audit errors found within the report'); |
There was a problem hiding this comment.
no longer necessary :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started writing a test that needed the
settingson the artifacts that generatesample_v2.jsonand I noticed they weren't there. Did a little housecleaning on the easy to update artifacts (deletingEventListenersandWebSQL, finally addingRobotsTxtandTapTargets), though at some point (maybe for v5) we should still do a whole-hog update of the artifacts, trace, and devtools log.At that point, surprisingly
sample_v2.jsonstill wasn't a validLH.Result, which isn't super important but is kind of annoying. To fix we just had tolhr.configSettings.auditModein the cleanup script (just hardcoded totrueto sidestep the travis issue mentioned in the comment in that file) andArtifacts.MeasureEntry(which makes up theTimingartifact) needed to not inherit fromPerformanceEntry.PerformanceEntryhas atoJSONmethod, but when we save artifacts as JSON methods aren't preserved, so the resulting object is no longer aPerformanceEntry. I just copied the properties over to the type definition rather than inherit now.