core(seo): add image alt to SEO category #8407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
requested review from
brendankenny,
exterkamp and
paulirish
as code owners
patrickhulce
commented
Apr 18, 2019
proto/sample_v2_round_trip.json
Outdated
| "lighthouseVersion": "4.3.0", | ||
| "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", | ||
| "runWarnings": [], | ||
| "stackPacks": [], |
There was a problem hiding this comment.
this happened on update:sample-json, is that bad @exterkamp ?
There was a problem hiding this comment.
based on appveyor it appears the answer is, yes this is bad :)
There was a problem hiding this comment.
Yes this is bad 😄 That is uh, slightly broken right now. Revert the stack packs line.
There was a problem hiding this comment.
oh right I even commented on that 😆 it's been a week...
paulirish
approved these changes
Apr 18, 2019
exterkamp
approved these changes
Apr 18, 2019
brendankenny
approved these changes
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like a good change to sweep in with breaking changes of a major version :)
Related Issues/PRs
fixes #8393