Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: import stack pack translations #8415

Merged
merged 4 commits into from
Apr 22, 2019
Merged

Conversation

exterkamp
Copy link
Member

@exterkamp exterkamp commented Apr 18, 2019

Summary
Importing new i18n strings as they come in. In this import: stack packs.
image

SEO groups will be imported in another PR, as it is separate in tc/

@brendankenny brendankenny changed the title i18n(import): stack packs [WIP] i18n(import): stack packs Apr 18, 2019
@exterkamp exterkamp changed the title [WIP] i18n(import): stack packs i18n(import): stack packs Apr 22, 2019
@exterkamp exterkamp marked this pull request as ready for review April 22, 2019 20:10
@brendankenny brendankenny changed the title i18n(import): stack packs i18n: import stack pack translations Apr 22, 2019
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SEO groups will be imported in another PR, as it is separate in tc/

seems like this isn't true? Are they all in here?

lighthouse-core/test/lib/i18n/i18n-test.js Show resolved Hide resolved
@exterkamp
Copy link
Member Author

SEO groups will be imported in another PR, as it is separate in tc/

seems like this isn't true? Are they all in here?

They are all in here in English as only lang for all langs (artifact of tc/ since they are being translated they appear as English in all langs). They just aren't translated yet. That's the follow up.

@brendankenny
Copy link
Member

They just aren't translated yet

oh, I see

@brendankenny brendankenny merged commit c05eb42 into master Apr 22, 2019
@brendankenny brendankenny deleted the import-i18n-stack-packs branch April 22, 2019 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants