core(font-display): do not use invalid sourceURLs #8535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, the custom URL was set manually. See #8534 (comment):
|
|
Thanks @westonruter! Updated accordingly :) |
brendankenny
approved these changes
Apr 24, 2019
| @@ -231,6 +231,8 @@ describe('Performance: Font Display audit', () => { | |||
| }); | |||
|
|
|||
| it('handles varied font-display declarations', async () => { | |||
| // Make sure we don't use sourceURL when it's not a valid URL, see https://github.com/GoogleChrome/lighthouse/issues/8534 | |||
| stylesheet.header.sourceURL = 'custom-attribute'; | |||
There was a problem hiding this comment.
any chance you could split this off into its own test? I could see us revising font-display at some point and having to reconfigure the tests and losing this very important line :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Apparently
/*# sourceURL=custom-url.css */sets thesourceURLin DevTools to whatever the attribute was, so we should handle that case.Related Issues/PRs
fixes #8534