Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core(stackpacks): proto uses icon_data_URL and stackPack test #8536

Merged
merged 8 commits into from
Apr 29, 2019
Merged

core(stackpacks): proto uses icon_data_URL and stackPack test #8536

merged 8 commits into from
Apr 29, 2019

Conversation

exterkamp
Copy link
Member

@exterkamp exterkamp commented Apr 23, 2019 •
edited
Loading

Summary
Main bugfix: icon_data_url -> icon_data_URL. Also added stack packs to artifacts so that sample_v2 has a stackPacks element so this kind of thing is moderately prevented.

fixes: #8537

@exterkamp exterkamp changed the title core(stackPacks): proto uses icon_data_URL and stackPack test core(stackpacks): proto uses icon_data_URL and stackPack test Apr 23, 2019
@brendankenny brendankenny mentioned this pull request Apr 24, 2019
Merged
patrickhulce
patrickhulce reviewed Apr 25, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but not sure my approval means much for proto-land :)

lighthouse-core/test/report/html/renderer/util-test.js Outdated Show resolved Hide resolved
lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html Outdated Show resolved Hide resolved
@brendankenny brendankenny mentioned this pull request Apr 26, 2019
Merged
brendankenny
brendankenny reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, but I'd like to wait for a call on #8633

lighthouse-core/test/report/html/renderer/util-test.js Outdated Show resolved Hide resolved
brendankenny
brendankenny approved these changes Apr 29, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with smoketest

lighthouse-cli/test/fixtures/dobetterweb/dbw_tester.html Show resolved Hide resolved
@brendankenny brendankenny merged commit 6fae88c into master Apr 29, 2019
@brendankenny brendankenny deleted the urlURL branch April 29, 2019 19:07
@brendankenny brendankenny mentioned this pull request Oct 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce left review comments

@brendankenny brendankenny brendankenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StackPack icon doesn't survive proto round trip
3 participants
@exterkamp @brendankenny @patrickhulce