Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

report(redesign): fireworks #8660

Merged
merged 6 commits into from
May 3, 2019
Merged

report(redesign): fireworks #8660

merged 6 commits into from
May 3, 2019

Conversation

connorjclark
Copy link
Collaborator

@connorjclark connorjclark commented Apr 27, 2019

#8185

run this in the now deployment:

const scoresContainer = document.querySelector('.lh-scores-container');
scoresContainer.classList.add('score100');
document.body.classList.add('dark');
scoresContainer.addEventListener('click', _ => {
  scoresContainer.classList.toggle('fireworks-paused');
});

Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% 2 nits

@@ -244,16 +244,16 @@ class ReportRenderer {

// TODO(hoten) - fireworks show will commence later.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuke

@@ -362,6 +367,7 @@
*/
.pyro {
display: none;
z-index: 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need pointer-events: none now. it's hard but possible to click on the fireworks div blocking the click on the gauge

Copy link
Member

@exterkamp exterkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 🎆 LGTM! Looks great in dark mode.

Future dream idea: slowly fade to dark theme, then start the 🎆

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs a test :)

// }
const scoresAll100 = report.reportCategories.every(cat => cat.score === 1);
if (!this._dom.isDevTools() && scoresAll100) {
if (scoresAll100) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to double check scoresAll100

@connorjclark
Copy link
Collaborator Author

needs a test :)

ez

@paulirish
Copy link
Member

paulirish commented Apr 29, 2019 via email

@connorjclark
Copy link
Collaborator Author

connorjclark commented Apr 29, 2019

Can we flip on dark mode for just scoresHeader?

i think it'd look weird dawg but @exterkamp suggests he'll try it post IO


edit by paul: it looks aiiiiight.

image

@paulirish
Copy link
Member

let's switch the whole report into dark mode if they are getting fireworks.

@paulirish paulirish merged commit 171ce4a into master May 3, 2019
@paulirish paulirish deleted the rd-fireworks branch May 3, 2019 15:06
@connorjclark connorjclark mentioned this pull request May 3, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants