-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report(redesign): fireworks #8660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
% 2 nits
@@ -244,16 +244,16 @@ class ReportRenderer { | |||
|
|||
// TODO(hoten) - fireworks show will commence later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nuke
@@ -362,6 +367,7 @@ | |||
*/ | |||
.pyro { | |||
display: none; | |||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need pointer-events: none
now. it's hard but possible to click on the fireworks div blocking the click on the gauge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍 🎆 LGTM! Looks great in dark mode.
Future dream idea: slowly fade to dark theme, then start the 🎆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs a test :)
// } | ||
const scoresAll100 = report.reportCategories.every(cat => cat.score === 1); | ||
if (!this._dom.isDevTools() && scoresAll100) { | ||
if (scoresAll100) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to double check scoresAll100
ez |
Can we flip on dark mode for just scoresHeader?
|
i think it'd look weird dawg but @exterkamp suggests he'll try it post IO edit by paul: it looks aiiiiight. |
let's switch the whole report into dark mode if they are getting fireworks. |
#8185
run this in the now deployment: