Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightwallet: Use gray circles & font for informative audits #8763

Merged
merged 1 commit into from
May 1, 2019
Merged

lightwallet: Use gray circles & font for informative audits #8763

merged 1 commit into from
May 1, 2019

Conversation

khempenius
Copy link
Collaborator

Screen Shot 2019-05-01 at 12 44 44 AM

Related Issues/PRs

@khempenius khempenius requested a review from paulirish as a code owner May 1, 2019 04:45
patrickhulce
patrickhulce reviewed May 1, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great in that report! :D

lighthouse-core/report/html/report-styles.css Outdated Show resolved Hide resolved
brendankenny
brendankenny reviewed May 1, 2019
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, just a test data suggestion

lighthouse-core/test/report/html/renderer/category-renderer-test.js Outdated Show resolved Hide resolved
lighthouse-core/test/report/html/renderer/category-renderer-test.js Outdated Show resolved Hide resolved
@khempenius
Copy link
Collaborator Author

Updated.

patrickhulce
patrickhulce approved these changes May 1, 2019
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brendankenny brendankenny merged commit 6abc48e into GoogleChrome:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce approved these changes

@brendankenny brendankenny brendankenny approved these changes

@paulirish paulirish Awaiting requested review from paulirish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khempenius @brendankenny @patrickhulce