Adds support for changing the options used when calling fetch() #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
commented
Mar 2, 2018
| @@ -181,6 +186,7 @@ class NetworkFirst { | |||
| try { | |||
| response = await fetchWrapper.fetch( | |||
| event.request, | |||
| this._fetchOptions, | |||
There was a problem hiding this comment.
There's a bug in the current codebase—the plugins array was being passed as the second parameter in this invocation, instead of the third parameter.
(The joy of positional arguments...)
gauntface
approved these changes
Mar 2, 2018
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin☠️ WARNING ☠️We are using 156% of our max size budget. Total Size: 22.81KB Gzipped: 9.12KB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
This is related to #1131.
I don't know if we want to mark it as fixed once this is merged—that issue tracks docs, and while this PR adds the code that's required, along with JSDocs, I guess we could still put together a standalone guide on d.g.c.