Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[com.google.fonts/check/kerningfornonligatedsequences] still reported after adding the kerning fixes #2628

Open
vv-monsalve opened this issue Aug 31, 2019 · 2 comments
Open

[com.google.fonts/check/kerningfornonligatedsequences] still reported after adding the kerning fixes #2628

vv-monsalve opened this issue Aug 31, 2019 · 2 comments
Labels
Check improvement proposal Profile: Universal Checks that evaluate adherence to the best practices shared among the type design community

Comments

@vv-monsalve
Copy link
Collaborator

Observed behaviour

This Warn keeps being reported even after the Kerning info was added.

Expected behaviour

To have a positive outcome once the info is introduced and do not receive the Warn anymore.

Resources and exact process needed to replicate

Here is a link to the las example of it, the QA6 report on Space Grotesk.
@felipesanches
Copy link
Collaborator

thanks, @vv-monsalve for posting this. I was on vacations in the past couple weeks. I will take some time to look at it more carefully soon.

@vv-monsalve vv-monsalve changed the title kerning info for non-ligated sequences com.google.fonts/check/kerningfornonligatedsequences still reported after adding the kerning fixes May 19, 2021
@vv-monsalve vv-monsalve changed the title com.google.fonts/check/kerningfornonligatedsequences still reported after adding the kerning fixes [com.google.fonts/check/kerningfornonligated] sequences still reported after adding the kerning fixes Jun 21, 2024
@vv-monsalve vv-monsalve changed the title [com.google.fonts/check/kerningfornonligated] sequences still reported after adding the kerning fixes [com.google.fonts/check/kerningfornonligatedsequences] still reported after adding the kerning fixes Jun 21, 2024
@solmatas
Copy link
Contributor

Hi!

I've added kerning for the f+i and f+l pairs, but I'm still receiving the warning. Can you help me understand why this might be happening?

@vv-monsalve vv-monsalve added the Profile: Universal Checks that evaluate adherence to the best practices shared among the type design community label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Check improvement proposal Profile: Universal Checks that evaluate adherence to the best practices shared among the type design community
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@felipesanches @solmatas @vv-monsalve