Add caveat about ligature caret support in ufo2ft to check rationale #3063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In both Fraunces and Recursive, a current FontBakery
WARN
is this:⚠ WARN: Are there caret positions declared for every ligature?
Unfortunately, this makes no mention of the fact that ligature carets currently aren’t supported in the FontMake UFO build process by ufo2ft. So, I just spent quite awhile adding ligature carets to Fraunces, for no (immediate) purpose.
It feels like something which might be worth calling out in the rationale, so that future UFO-based projects can either ignore this
WARN
for now, or approach adding these in a post-process instead of directly to UFOs.So, this simply adds the following to the rationale:
To Do
This PR is somewhat more for discussion than an immediate suggestion ... do we add this kind of information to rationales, when it has an unknown "expiration date"? Have I written it clearly enough, or should I approach it differently?
If it does seem worth merging, I could later work on these to-do items. Thanks!
CHANGELOG.md
github/pages
, which is stuck)