GolangCI-lint updating version to 1.30 (#1785)

Add exportloopref which is a successor of obsoleted scopelint.
Disable unnecessaryDefer which are located right before return.

Co-authored-by: Mark Mandel <markmandel@google.com>

.golangci.yml

@@ -46,6 +46,7 @@ output:
 
 linters:
   enable:
+    - exportloopref
     - deadcode
     - megacheck
     - govet
@@ -77,6 +78,7 @@ linters-settings:
     disabled-checks:
       - paramTypeCombine
       - unnamedResult
+      - unnecessaryDefer
     settings: # settings passed to gocritic
       hugeParam:
         sizeThreshold: 512

build/build-image/Dockerfile

@@ -68,7 +68,7 @@ RUN curl -L  ${HELM_URL} > /tmp/helm.tar.gz \
 RUN echo "source <(helm completion bash)" >> /root/.bashrc
 
 # install golang-ci linter
-RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOPATH/bin v1.27.0
+RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $GOPATH/bin v1.30.0
 
 #
 #  \ \      / /__| |__  ___(_) |_ ___

cmd/controller/main.go

@@ -247,8 +247,8 @@ func parseEnvFlags() config {
 	viper.SetDefault(sidecarMemoryLimitFlag, "0")
 	viper.SetDefault(pullSidecarFlag, false)
 	viper.SetDefault(sdkServerAccountFlag, "agones-sdk")
-	viper.SetDefault(certFileFlag, filepath.Join(base, "certs/server.crt"))
-	viper.SetDefault(keyFileFlag, filepath.Join(base, "certs/server.key"))
+	viper.SetDefault(certFileFlag, filepath.Join(base, "certs", "server.crt"))
+	viper.SetDefault(keyFileFlag, filepath.Join(base, "certs", "server.key"))
 	viper.SetDefault(enablePrometheusMetricsFlag, true)
 	viper.SetDefault(enableStackdriverMetricsFlag, false)
 	viper.SetDefault(stackdriverLabels, "")

test/e2e/framework/framework.go

@@ -152,7 +152,7 @@ func NewFromFlags() (*Framework, error) {
 		return nil, err
 	}
 
-	viper.SetDefault(kubeconfigFlag, filepath.Join(usr.HomeDir, "/.kube/config"))
+	viper.SetDefault(kubeconfigFlag, filepath.Join(usr.HomeDir, ".kube", "config"))
 	viper.SetDefault(gsimageFlag, "gcr.io/agones-images/udp-server:0.21")
 	viper.SetDefault(pullSecretFlag, "")
 	viper.SetDefault(stressTestLevelFlag, 0)

test/load/allocation/allocationload.go

@@ -35,7 +35,7 @@ func main() {
 	if err != nil {
 		logrus.Fatalf("Unable to determine the current user: %v", err)
 	}
-	kubeconfig := flag.String("kubeconfig", filepath.Join(usr.HomeDir, "/.kube/config"),
+	kubeconfig := flag.String("kubeconfig", filepath.Join(usr.HomeDir, ".kube", "config"),
 		"kube config path, e.g. $HOME/.kube/config")
 	fleetName := flag.String("fleet_name", "simple-udp", "The fleet name that the tests will run against")
 	qps := flag.Int("qps", 1000, "The QPS value that will overwrite the default value")