Add Annotations validation for Template ObjectMeta

Check value and key length for Annotations which belongs to Fleet and
GameServerSpec.

pkg/apis/agones/v1/common.go

@@ -17,6 +17,7 @@ package v1
 import (
 	"fmt"
 
+	apivalidation "k8s.io/apimachinery/pkg/api/validation"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	metav1validation "k8s.io/apimachinery/pkg/apis/meta/v1/validation"
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -86,5 +87,16 @@ func validateObjectMeta(objMeta metav1.ObjectMeta) []metav1.StatusCause {
 			})
 		}
 	}
+	errs = apivalidation.ValidateAnnotations(objMeta.Annotations,
+		field.NewPath("annotations"))
+	if len(errs) != 0 {
+		for _, v := range errs {
+			causes = append(causes, metav1.StatusCause{
+				Type:    metav1.CauseTypeFieldValueInvalid,
+				Field:   "annotations",
+				Message: v.Error(),
+			})
+		}
+	}
 	return causes
 }

pkg/apis/agones/v1/gameserver_test.go

@@ -427,6 +427,33 @@ func TestGameServerValidate(t *testing.T) {
 	assert.Len(t, causes, 1)
 	assert.Equal(t, "labels", causes[0].Field)
 
+	gs.Spec.Template.ObjectMeta.Labels = make(map[string]string)
+	gs.Spec.Template.ObjectMeta.Labels["agones.dev/longValueKey"] = longName
+	causes, ok = gs.Validate()
+	assert.False(t, ok)
+	assert.Len(t, causes, 1)
+	assert.Equal(t, "labels", causes[0].Field)
+
+	// Validate Labels and Annotations
+	gs.Spec.Template.ObjectMeta.Annotations = make(map[string]string)
+	gs.Spec.Template.ObjectMeta.Annotations[longName] = longName
+	causes, ok = gs.Validate()
+	assert.False(t, ok)
+	assert.Len(t, causes, 2)
+
+	// No errors if valid Annotation was used
+	gs.Spec.Template.ObjectMeta.Labels = make(map[string]string)
+	gs.Spec.Template.ObjectMeta.Annotations = make(map[string]string)
+	gs.Spec.Template.ObjectMeta.Annotations["agones.dev/shortName"] = "shortValue"
+	causes, ok = gs.Validate()
+	assert.True(t, ok)
+	assert.Len(t, causes, 0)
+
+	gs.Spec.Template.ObjectMeta.Annotations["agones.dev/shortName"] = longName
+	causes, ok = gs.Validate()
+	assert.True(t, ok)
+	assert.Len(t, causes, 0)
+
 	gs = GameServer{
 		Spec: GameServerSpec{
 			Ports: []GameServerPort{{Name: "one", PortPolicy: Passthrough, ContainerPort: 1294}, {PortPolicy: Passthrough, Name: "two", HostPort: 7890}},