Skip to content

Commit

Permalink
Added a couple of comments related to GAMESERVERS_NAMESPACE flag
Browse files Browse the repository at this point in the history
  • Loading branch information
alexey-kremsa-globant committed Jun 16, 2020
1 parent f7d8683 commit f5b58bb
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,8 @@ test-e2e:
$(MAKE) test-e2e-integration
$(MAKE) test-e2e-failure


# If GAMESERVERS_NAMESPACE is empty - random namespace will be created
test-e2e-integration: FEATURE_GATES ?= $(ALPHA_FEATURE_GATES)
test-e2e-integration: GAMESERVERS_NAMESPACE ?= ""
test-e2e-integration: $(ensure-build-image)
Expand Down
2 changes: 2 additions & 0 deletions build/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -477,6 +477,8 @@ These tests validate Agones flow from start to finish.

It uses the KUBECONFIG to target a Kubernetes cluster.

Use `GAMESERVERS_NAMESPACE` flag to provide a namespace or leave it empty in order to create and use a random one.

See [`make minikube-test-e2e`](#make-minikube-test-e2e) to run end-to-end tests on Minikube.

#### `make test-e2e-integration`
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/framework/framework.go
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ func GetAllocation(f *agonesv1.Fleet) *allocationv1.GameServerAllocation {
}}
}

// CreateNamespace creates a namespace in the test cluster
// CreateNamespace creates a namespace and a service account in the test cluster
func (f *Framework) CreateNamespace(namespace string) error {
kubeCore := f.KubeClient.CoreV1()
ns := &corev1.Namespace{
Expand Down

0 comments on commit f5b58bb

Please sign in to comment.