Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrument Kubernetes API and Allocator with Tracing #1012

Open
cyriltovena opened this issue Aug 24, 2019 · 3 comments
Open

Instrument Kubernetes API and Allocator with Tracing #1012

cyriltovena opened this issue Aug 24, 2019 · 3 comments
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc awaiting-maintainer Block issues from being stale/obsolete/closed help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones

Comments

@cyriltovena
Copy link
Collaborator

cyriltovena commented Aug 24, 2019

Is your feature request related to a problem? Please describe.
It would be great to be able to trace requests and their downstream pair together to troubleshoot issues.

Describe the solution you'd like
Currently we are using an old version of OpenCensus, but if we move to OpenTelemetry we should be able to add tracing to the Kubernetes API rest client and the allocator.

Open Telemetry doesn't seems to be available yet but the recommendations seems to be to use OpenCensus and OpenTracing together for now

I want to start instrumenting production code today. What should I use?
We are still working on the first production-ready release of OpenTelemetry. For those who
want to start instrumenting production code immediately, use either OpenCensus or
OpenTracing. OpenTelemetry will provide compatibility bridges and there is no need to wait
for production-ready OpenTelemetry APIs in your language.

For now we should update GRPC version and OpenCensus version to match then instrument the http allocator service and the Kubernetes REST client using OpenTracing (https://opentracing.io/).

Describe alternatives you've considered
Wait for OpenTelemetry ?

Additional context

@cyriltovena cyriltovena added kind/feature New features for Agones area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc help wanted We would love help on these issues. Please come help us! and removed help wanted We would love help on these issues. Please come help us! labels Aug 24, 2019
@markmandel markmandel added the help wanted We would love help on these issues. Please come help us! label Jul 28, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2023

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label May 1, 2023
@markmandel
Copy link
Member

We do need to move to OTel at some point... so if we do that, we should probably do this. How do other people feel?

@github-actions github-actions bot removed the stale Pending closure unless there is a strong objection. label May 15, 2023
@github-actions
Copy link

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Jun 15, 2023
@roberthbailey roberthbailey added awaiting-maintainer Block issues from being stale/obsolete/closed and removed stale Pending closure unless there is a strong objection. labels Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc awaiting-maintainer Block issues from being stale/obsolete/closed help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

3 participants