Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Build cache cpp-sdk-build contains unnecessary archives #1136

Closed
aLekSer opened this issue Oct 23, 2019 · 1 comment · Fixed by #1142
Closed

CI: Build cache cpp-sdk-build contains unnecessary archives #1136

aLekSer opened this issue Oct 23, 2019 · 1 comment · Fixed by #1142
Labels
area/performance Anything to do with Agones being slow, or making it go faster. area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Milestone

Comments

@aLekSer
Copy link
Collaborator

aLekSer commented Oct 23, 2019

Currently the following files are added to build cache for every new build:

agonessdk-1.0.0-b8432d1-linux-arch_64.tar.gz

What happened:

What you expected to happen:

The moment it happened is here:

cd $(package_path) && tar cf $(build_path)/agonessdk-$(VERSION)-linux-arch_64.tar.gz *

I expect that package_path (.install) would be used to store all the archives. And .build would contain only files needed for the build.

How to reproduce it (as minimally and precisely as possible):
du -sh ./sdks/cpp/.build
make archive
du -sh ./sdks/cpp/.build - becomes significantly bigger but should not.

Anything else we need to know?:

Environment:

  • Agones version:
  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • Install method (yaml/helm):
  • Troubleshooting guide log(s):
  • Others:
@aLekSer aLekSer added the kind/bug These are bugs. label Oct 23, 2019
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break area/performance Anything to do with Agones being slow, or making it go faster. labels Oct 23, 2019
@markmandel
Copy link
Member

This is why the cpp build cache is 6+ GB at the moment.

Worth noting, changing this position of these artifacts will affect the cloudbuild.yaml and also the do-release target (and maybe some others) so it's worth a review to see what can be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Anything to do with Agones being slow, or making it go faster. area/tests Unit tests, e2e tests, anything to make sure things don't break kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants