Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quickstart: Create a Fleet Autoscaler with Webhook Policy #1151

Closed
moesy opened this issue Oct 25, 2019 · 2 comments · Fixed by #1165
Closed

Quickstart: Create a Fleet Autoscaler with Webhook Policy #1151

moesy opened this issue Oct 25, 2019 · 2 comments · Fixed by #1165
Assignees
@aLekSer
Labels
area/examples Examples. Usually found in the `examples` directory good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Milestone
1.2.0

Comments

@moesy
Copy link
Contributor

moesy commented Oct 25, 2019

https://agones.dev/site/docs/getting-started/create-webhook-fleetautoscaler/

The "Getting Started" sections apply Kubernetes resources through files stored on gist. When we get to the "Create X509 Root and Webhook certificates" section however the final step:

# Copy the output of the command above and replace the caBundle field in your text editor:
vim $GOPATH/src/agones.dev/agones/examples/webhookfleetautoscalertls.yaml

requires the user to edit the webhookfleetautoscalertls.yaml file before applying it to a cluster.

To provide greater clarity to users it might be helpful to call out installing golang and fetching the agones package in the prerequisites section. Alternatively the steps could be changed download the file from gist and make a local edit.
@roberthbailey
Copy link
Member

I like your suggestion of downloading the file. Then we can point to the version of the file in the proper release branch (e.g. download https://raw.githubusercontent.com/googleforgames/agones/release-1.0.0/examples/webhookfleetautoscalertls.yaml) and we will know that the file is compatible with the other files in the walkthrough (and the instructions, which can change between releases).

@roberthbailey roberthbailey added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones area/examples Examples. Usually found in the `examples` directory labels Oct 25, 2019
@roberthbailey roberthbailey added this to the 1.2.0 milestone Oct 25, 2019
@aLekSer
Copy link
Collaborator

aLekSer commented Oct 28, 2019

That's right we should review and updates documents on FleetAutoscaler.

/assign alekser

aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
9d585cb 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
97edd2b 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
ead6d69 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
61d1a27 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
16ef330 
Switch from local path to github link.
Closes googleforgames#1151.
@aLekSer aLekSer mentioned this issue Oct 30, 2019
Merged
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
0eba665 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 30, 2019
@aLekSer
Fix using GOPATH in the guides
cc1153e 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 31, 2019
@aLekSer
Fix using GOPATH in the guides
c304c53 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 31, 2019
@aLekSer
Fix using GOPATH in the guides
d5ab49f 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Oct 31, 2019
@aLekSer
Fix using GOPATH in the guides
740d70b 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Nov 1, 2019
@aLekSer
Fix using GOPATH in the guides
5aed24f 
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Nov 1, 2019
@aLekSer
Fix using GOPATH in the guides
cd88dd1 
Add ghrelase shotcode which uses one param - file prefix.
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Nov 5, 2019
@aLekSer
Fix using GOPATH in the guides
1dd1c77 
Add ghrelase shotcode which uses one param - file prefix.
Switch from local path to github link.
Closes googleforgames#1151.
aLekSer added a commit to aLekSer/agones that referenced this issue Nov 5, 2019
@aLekSer
Fix using GOPATH in the guides
ab4e1d0 
Add ghrelase shotcode which uses one param - file prefix.
Switch from local path to github link.
Closes googleforgames#1151.
markmandel pushed a commit that referenced this issue Nov 5, 2019
@aLekSer @markmandel
Fix using GOPATH in the guides (#1165)
5a1b769 
Add ghrelase shotcode which uses one param - file prefix.
Switch from local path to github link.
Closes #1151.
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this issue Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Fix using GOPATH in the guides (googleforgames#1165)
0cd280b 
Add ghrelase shotcode which uses one param - file prefix.
Switch from local path to github link.
Closes googleforgames#1151.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aLekSer aLekSer

Labels
area/examples Examples. Usually found in the `examples` directory good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Docs: Fix using GOPATH in the guides, added shortcode ghrelease aLekSer/agones
3 participants
@aLekSer @moesy @roberthbailey