Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UE4 plugin stores configuration data in per-user rather than per-project config #1351

Closed
drichardson opened this issue Feb 19, 2020 · 2 comments · Fixed by #1352
Closed

UE4 plugin stores configuration data in per-user rather than per-project config #1351

drichardson opened this issue Feb 19, 2020 · 2 comments · Fixed by #1352
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Milestone
1.4.0

Comments

@drichardson
Copy link
Contributor

The UE4 plugin saved config settings to Saved/Config/Windows/Game.ini. This directory is typically not checked into source control and is for per-user, rather than per-project settings. The UE4 plugin should save config settings to Config/DefaultGame.ini instead.

What happened:

After updating Debug Logging Enabled in Agones Project Settings, a per-user configuration file was updated.

What you expected to happen:

One of the per-project configuration files should be updated, like Config/DefaultGame.ini.

How to reproduce it (as minimally and precisely as possible):

  1. In UE4, go to Menu > Project Settings > Plugins > Agones
  2. Enable Debug Logging Enabled

Result: Saved/Config/Windows/Game.ini was updated.

image

Anything else we need to know?:

Environment:

  • Agones version: 1.3.0
  • Kubernetes version (use kubectl version): n/a
  • Cloud provider or hardware configuration: n/a
  • Install method (yaml/helm): n/a
  • Troubleshooting guide log(s): n/a
  • Others: Windows 10 Pro, Unreal Engine 4.24.2
@drichardson drichardson added the kind/bug These are bugs. label Feb 19, 2020
@drichardson
Copy link
Contributor Author

I'm pretty sure the solution to this is to set the defaultconfig flag in the UCLASS macro for UAgonesSettings. I'm testing this out now.

@drichardson
Copy link
Contributor Author

Yes, that works. Preparing a PR now.

FWIW, Houdini Engine for Unreal does the same thing for their settings.

@drichardson drichardson mentioned this issue Feb 19, 2020
Merged
@markmandel markmandel added the area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc label Feb 20, 2020
@markmandel markmandel added this to the 1.4.0 milestone Feb 20, 2020
markmandel added a commit that referenced this issue Feb 20, 2020
@drichardson @markmandel
Use the defaultconfig UCLASS specifier so that UE4 Agones Settings ar…
c2aa89a 
…e saved (#1352)

to the per-project configuration file, rather than the per-user
configuration file.

Fixes #1351.

Co-authored-by: Mark Mandel <mark.mandel@gmail.com>
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this issue Oct 23, 2020
@drichardson @markmandel @ilkercelikyilmaz
Use the defaultconfig UCLASS specifier so that UE4 Agones Settings ar…
9af233f 
…e saved (googleforgames#1352)

to the per-project configuration file, rather than the per-user
configuration file.

Fixes googleforgames#1351.

Co-authored-by: Mark Mandel <mark.mandel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs.
Projects
None yet
Milestone
1.4.0
Development

Successfully merging a pull request may close this issue.

Save UE4 Plugin settings to per-project config file
2 participants
@drichardson @markmandel