Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestFleetAggregatedPlayerStatus #1592

Closed
markmandel opened this issue May 28, 2020 · 0 comments · Fixed by #1606
Closed

Flaky: TestFleetAggregatedPlayerStatus #1592

markmandel opened this issue May 28, 2020 · 0 comments · Fixed by #1606
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Milestone
1.7.0

Comments

@markmandel
Copy link
Member

Flaky test:

--- FAIL: TestFleetAggregatedPlayerStatus (97.63s)
    fleet_test.go:1270: Could not message GameServer: read udp 192.168.10.2:54085->104.198.11.54:7229: i/o timeout

Sounds like some UDP packets are getting dropped. We could wrap this section that is failing in a retry, which should solve the flakiness.
@markmandel markmandel added kind/bug These are bugs. help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! area/tests Unit tests, e2e tests, anything to make sure things don't break labels May 28, 2020
markmandel added a commit to markmandel/agones that referenced this issue Jun 2, 2020
@markmandel
Flaky: TestFleetAggregatedPlayerStatus
0163c7d 
Added retry logic to UDP packet send and receive.

Had to adjust the test condition a little, but I think that's not a
concern here, as we mainly want to fail if the SDK isn't working,
whereas we now many get extra times that it is.

Closes googleforgames#1592
@markmandel markmandel mentioned this issue Jun 2, 2020
Merged
markmandel added a commit to markmandel/agones that referenced this issue Jun 2, 2020
@markmandel
Flaky: TestFleetAggregatedPlayerStatus
41ed232 
Added retry logic to UDP packet send and receive.

Had to adjust the test condition a little, but I think that's not a
concern here, as we mainly want to fail if the SDK isn't working,
whereas we now many get extra times that it is.

Closes googleforgames#1592
aLekSer pushed a commit that referenced this issue Jun 2, 2020
@markmandel
Flaky: TestFleetAggregatedPlayerStatus (#1606)
1d21e03 
Added retry logic to UDP packet send and receive.

Had to adjust the test condition a little, but I think that's not a
concern here, as we mainly want to fail if the SDK isn't working,
whereas we now many get extra times that it is.

Closes #1592
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this issue Oct 23, 2020
@markmandel @ilkercelikyilmaz
Flaky: TestFleetAggregatedPlayerStatus (googleforgames#1606)
521ad00 
Added retry logic to UDP packet send and receive.

Had to adjust the test condition a little, but I think that's not a
concern here, as we mainly want to fail if the SDK isn't working,
whereas we now many get extra times that it is.

Closes googleforgames#1592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/bug These are bugs.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

Flaky: TestFleetAggregatedPlayerStatus markmandel/agones
1 participant
@markmandel