Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .helmignore to Helm chart #168

Closed
fooock opened this issue Apr 7, 2018 · 6 comments
Closed

Add .helmignore to Helm chart #168

fooock opened this issue Apr 7, 2018 · 6 comments
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/design Proposal discussing new features / fixes and how they should be implemented
Milestone

Comments

@fooock
Copy link
Contributor

fooock commented Apr 7, 2018

To ignore common files like in this chart

@markmandel markmandel added kind/design Proposal discussing new features / fixes and how they should be implemented area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Apr 7, 2018
@markmandel
Copy link
Member

Just so I understand this properly - what is the exact purpose of a .helmignore file? Where would it go in the repo? @enocom I think you mentioned this as well. I couldn't find any specific docs on this other than this single reference.

@markmandel
Copy link
Member

Sorry, I got this wrong, it was @Kuqd who mention this in chat yesterday.

@cyriltovena
Copy link
Collaborator

What do we have to ignore ?

@alexandrem
Copy link

alexandrem commented Apr 10, 2018

The .helmignore is to prevent parsing non helm chart related files in the project workspace and sending them to Tiller.

This becomes especially important for generated builds or large asset files, because you might encounter the famous

Error: grpc: received message length xxx exceeding the max size xxx

or

Error: grpc: received message larger than max (xxx vs. xxx)

error message when running helm commands (e.g helm install or helm list) with local charts, which is common during development.

@cyriltovena
Copy link
Collaborator

There is nothing to ignore so far. Should we close and reopen if required?

@alexandrem
Copy link

I guess it wouldn't hurt to add the default ignore file generated by helm itself:

# Patterns to ignore when building packages.
# This supports shell glob matching, relative path matching, and
# negation (prefixed with !). Only one pattern per line.
.DS_Store
# Common VCS dirs
.git/
.gitignore
.bzr/
.bzrignore
.hg/
.hgignore
.svn/
# Common backup files
*.swp
*.bak
*.tmp
*~
# Various IDEs
.project
.idea/
*.tmproj

@markmandel markmandel added this to the 0.2.0 milestone May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/design Proposal discussing new features / fixes and how they should be implemented
Projects
None yet
Development

No branches or pull requests

4 participants