CI: htmltest with 404 status does not treated as a failure on make hugo-test step

[aLekSer]

htmltest behaves strange, it show lots of hash does not exist errors and some 404 errors but the result is successful.

What happened:

  hash does not exist --- site/docs/guides/client-sdks/cpp/index.html --> /site/docs/guides/client-sdks/#watchgameserver-function-gameserver
  Non-OK status: 404 --- site/docs/guides/client-sdks/cpp/index.html --> https://github.com/openssl/openssl/blob/master/NOTES.WIN
site/docs/guides/client-sdks/rust/index.html
...
========================================================================
✘✘✘ failed in 509.190088ms
28 errors in 111 documents
make[1]: Leaving directory '/workspace/build'

https://console.cloud.google.com/cloud-build/builds/d87378b2-7dc8-4ee7-a127-8db3c1cc684d;step=17?project=agones-images
What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

make hugo-test

Anything else we need to know?:

Environment:

• Agones version:
• Kubernetes version (use kubectl version):
• Cloud provider or hardware configuration:
• Install method (yaml/helm):
• Troubleshooting guide log(s):
• Others:

[aLekSer]

I assume that this website.mk target should return latest error out of the loop:

"mkdir -p /tmp/website && cp -r $(mount_path)/site/public /tmp/website/site && htmltest -c $(mount_path)/site/htmltest.yaml /tmp/website" && \
	break || sleep 60;

I have created examples to see the error output:

Big makefile example

hugo-test: site-static-preview
	for i in 1 2 3 4 5; \
		do echo "Html Test: Attempt $$i" && \
		  docker run --rm -t -e "TERM=xterm-256color" $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) bash -c \
			"mkdir -p /tmp/website && cp -r $(mount_path)/site/public /tmp/website/site && htmltest  -c $(mount_path)/site/htmltest.yaml /tmp/website" && \
	break || sleep 60; done

hugo-test2:
	for i in 1 2 3 4 5; \
		do echo "Html Test: Attempt $$i" && \
		  docker run --rm -t -e "TERM=xterm-256color" $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) bash -c \
			"ssl" && \
	break || sleep 1; done


hugo-test3:
	for i in 1 2 3 4 5; \
		do echo "Html Test: Attempt $$i" && \
		  docker run --rm -t -e "TERM=xterm-256color" $(common_mounts) $(DOCKER_RUN_ARGS) $(build_tag) bash -c \
			"ssl" ; done

Output :

>make hugo-test3
for i in 1 2 3 4 5; \
        do echo "Html Test: Attempt $i" && \
          docker run --rm -t -e "TERM=xterm-256color" <mounts>  agones-build:8f335b4456 bash -c \
                "ssl" ; done
Html Test: Attempt 1
bash: ssl: command not found
...
Html Test: Attempt 5
bash: ssl: command not found
includes/website.mk:78: recipe for target 'hugo-test3' failed
make: *** [hugo-test3] Error 127

>make hugo-test2
...
Html Test: Attempt 5
bash: ssl: command not found
>echo $? 
0