Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simple-game-server to 0.3 #2045

Closed
roberthbailey opened this issue Apr 2, 2021 · 5 comments
Closed

Update simple-game-server to 0.3 #2045

roberthbailey opened this issue Apr 2, 2021 · 5 comments
Assignees
Labels
kind/feature New features for Agones
Milestone

Comments

@roberthbailey
Copy link
Member

Now that #2037 merged we need to push a new image of the simple game server (it will be the first multi-arch image).

/cc @jeremyje
/assign @roberthbailey

@roberthbailey roberthbailey added the kind/feature New features for Agones label Apr 2, 2021
@markmandel
Copy link
Member

Included with this, do we want to update:
https://github.com/googleforgames/agones/blob/main/examples/simple-game-server/Makefile#L109

Which is what prints out the image tag for release notes as well?

@roberthbailey
Copy link
Member Author

If I update line 38 of that file I (to build and push the new image) I think that will do it, right?

@markmandel
Copy link
Member

To probably phrase things in a more coherent manner - in the release notes, do we need to do anything special to say "these images are both linux and windows containers" ?

@roberthbailey
Copy link
Member Author

@jeremyje and I had a chat about that this morning, and I think the conclusion is that we can mention it in the release notes but we shouldn't need to point to the linux & windows versions of the containers, just the multi-arch container.

@jeremyje said that "debian, alpine, ubuntu all use multi arch now" (in addition to a bunch of other common containers like golang) so we don't think this will be concerning for any of our users.

@roberthbailey
Copy link
Member Author

This was done in #2048 and #2049.

@roberthbailey roberthbailey added this to the 1.14.0 milestone Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones
Projects
None yet
Development

No branches or pull requests

2 participants